Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to "I don't have this page" on the settings page doesn't properly save the setting #201

Open
4 of 11 tasks
tacoverdo opened this issue Dec 24, 2024 · 2 comments · May be fixed by #205
Open
4 of 11 tasks
Assignees
Labels
bug Something isn't working

Comments

@tacoverdo
Copy link

tacoverdo commented Dec 24, 2024

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

https://github.com/user-attachments/assets/04e6ba78-b99b-4bc0-8bda-32000213f063
Setting the FAQ page to "I don't have this page yet" and then clicking save triggers a reload of the page, after which the FAQ page is set to "I have this page".

To Reproduce

Step-by-step reproduction instructions

  1. Go to the PP settings.

  2. Set your FAQ page to My site doesn't need this page and save the page.

  3. Now change the FAQ page setting to "I don't have this page yet", and click Save.

  4. Expected results

  5. After reloading, the setting should remain at "I don't have this page yet".

Actual results

  1. The setting switches to "I have this page".

Screenshots, screen recording, code snippet

See screen recording above.

Technical info

  • If relevant, which editor is affected (or editors):
  • Block Editor
  • Gutenberg Editor
  • Elementor Editor
  • Classic Editor
  • Other:
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other:

Used versions

  • Device you are using: Macbook
  • Operating system: OSX Sonoma 14.4
  • PHP version: 8.4
  • WordPress version: 6.7.1
  • WordPress Theme: Home-made
  • Plugin version: 1.0.1
@tacoverdo tacoverdo added the bug Something isn't working label Dec 24, 2024
@ilicfilip
Copy link
Collaborator

Weird, it works as expected for me.

@ilicfilip ilicfilip linked a pull request Dec 27, 2024 that will close this issue
3 tasks
@rhyswynne
Copy link

I've noticed this issue as well.

Device you are using: Macbook
Operating system: OSX Sonoma 14.4.1
PHP version: 8.2.26
WordPress version: 6.7.1
WordPress Theme: Custom Theme
Plugin version: 1.0.1

Workflow very similar to Taco's above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants