Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistant Naming #19

Open
peardox opened this issue Aug 23, 2022 · 2 comments
Open

Inconsistant Naming #19

peardox opened this issue Aug 23, 2022 · 2 comments
Assignees
Labels
Awaiting Feedback Waiting for feedback from submitter or others.

Comments

@peardox
Copy link
Contributor

peardox commented Aug 23, 2022

PyTorch is the name of a Project

TTorch is in PyTorch and the PyModuleName is torch
TTorchVision is in TTorchVision PyModuleName is torchvision

Suggest PyTorch becomes Torch then I'll also add TTorchAudio (for compete PyTorch support)

Also in the YT https://www.youtube.com/watch?v=ssIKb3nJw5c&t=1040s there are some modules PyScripter mentions we haven't got - seems sensible to add them

@lmbelo
Copy link
Member

lmbelo commented Aug 23, 2022

PyTorch is the Python version of Torch. It is named torch on PYPI. What is the issue?

@lmbelo lmbelo self-assigned this Aug 23, 2022
@lmbelo lmbelo added the Awaiting Feedback Waiting for feedback from submitter or others. label Aug 23, 2022
@peardox
Copy link
Contributor Author

peardox commented Aug 23, 2022

PyTorch.pas = TPyTorch = torch Package
TorchVision.pas = TTorchVision = torchvision Package

Everything else (apart from OpenCV = cv2 which is OK I guess) has same naming throught

PyTorchVision.pas = TPyTorchVision = torchvision Package also sorta works

Although conda (commented out) calls it pytorch while pip calls it torch and as we're mainly using pip seems sensible to stick to pip naming where possible as that's how Python people will refer to them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Feedback Waiting for feedback from submitter or others.
Projects
None yet
Development

No branches or pull requests

2 participants