Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOT A BUG] PostLoginEvent and LoginEvent not firing without LimboPlayer#disconnect call #51

Open
kyngs opened this issue Apr 18, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@kyngs
Copy link

kyngs commented Apr 18, 2022

Describe the bug
When I add a callback to LoginLimboRegisterEvent, the LoginEvent and PostLoginEvent stop firing completely for all plugins.

To Reproduce
Steps to reproduce the behavior:

  1. Add a listener for LoginEvent and PostLoginEvent and put a breakpoint/print statement to it
  2. Add a listener for LoginLimboRegisterEvent and add a callback in it
  3. Try to connect
  4. Observe, that our LoginEvent and PostLoginEvent did not fire

Expected behavior
LoginEvent and PostLoginEvent should fire normally.

Screenshots
Not applicable

Server Info (please complete the following information):

Additional context
I suspect that this is because LimboAPI takes control over the login process when you add a callback, but forgets to fire applicable events which would be fired under a normal scenario.

@kyngs kyngs added the bug Something isn't working label Apr 18, 2022
@kyngs
Copy link
Author

kyngs commented Apr 18, 2022

I've found out, that I need to call the LimboPlayer#disconnect method for proper handling.
I will leave this open, if you want to add further documentation.

@hevav hevav added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jul 13, 2022
@hevav hevav changed the title [BUG] PostLoginEvent and LoginEvent not firing [NOT A BUG] PostLoginEvent and LoginEvent not firing without LimboPlayer#disconnect call Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants