Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying the "Mute" flag on the display #126

Open
Pako2 opened this issue Sep 18, 2023 · 1 comment
Open

Displaying the "Mute" flag on the display #126

Pako2 opened this issue Sep 18, 2023 · 1 comment

Comments

@Pako2
Copy link

Pako2 commented Sep 18, 2023

I noticed the incorrect display of the "Mute" flag on the display.
This display is only true if the mute function is controlled by a rotary encoder.
On the contrary, in the case of using the remote control or the web interface, the display of the "Mute" flag does not correspond to the actual situation.
I could handle this problem myself, but I would like my code to be as little different from the official version as possible. I already have too many of those differences. Then it is very difficult to incorporate the news in the official version into my modified code.
I'm not even 100% sure (only 99%) that the described behavior also occurs on devices with the official version of the code...
If not, then I'm very sorry for reporting a bug that doesn't exist!

@Pako2
Copy link
Author

Pako2 commented Sep 23, 2023

In the end, I decided to solve it myself. It worked pretty well, but I found that it didn't really suit me.
I arrived at a completely different (actually completely opposite) solution:
Before, I didn't like that the word "Mute" was sometimes visible, sometimes not (even though the mute state was selected).
Now the word "Mute" (instead of the name of the station or track) is no longer displayed on the display at all.
The mute status is sufficiently indicated by the volume indicator.
This is far more useful as it is immediately visible when a track or station change occurs during the mute state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant