Pins and comments

[JoshuaDickerson]

@EJEHardenberg @the-hobbes

It seems to me that pins with comments attached should come down in the comments JSON payload from the server (and don't). Currently when I pull comments created in the forum, they come down as pin: "0", so I assume the intention was to have pins included with comments?

It doesn't make sense for the client to have to make 2 calls to the api, and then have to do the work of combining the pins with the comments.

If I comment on a pin, it should show up in the forum (maybe with a special icon indicating that it is a pin) and I should be able to click on it, and be brought to that point on the map.

Also.. I should be able to reply to that specific pin and have my comment be clickable (and decorated) as well.

Thoughts?

[JoshuaDickerson]

Comments have an ID. Pins should also have an ID, and if the comment came from someone adding a pin, the IDs should be the same (or at least be referenced within each other).

[EdgeCaseBerg]

Both comments and pins have ID's to reference each other. You can see it in the schema here and are updated by triggers to be associated with each other. We can't have them be the same since they ID's are auto-increment.

Comments and comments come down with their associated ID's so that anyone can use the ?id= methods to retrieve the related content. Combining the data is really more of a client side activity over a restful one. We could look into implementing this for 2.0 perhaps. But having an additional list for each comment is going to create much large responses, which would really be my only big concern because we don't want to kill a clients data limits.

If I'm not mistake, I believe that @popwarfour has the click on a comment/pin and be brought to the map feature? As does the web app. So maybe this issue is old and can be closed?