Add support for rowspan

[dmrickey]

For cases like this where a single actor has multiple rows, it would be ideal if this last column was able to span all three rows so it doesn't force the first row to be "too tall"

edit: Actually, looking at the pic again, it would also be nice to do this for the first column so that it can be vertically centered within its own actor "row"
edit x2: And same for that classes entry, rowspan 2 would be ideal for an actor that has multiple classes

[EddieDover]

The reason this hasn't been implemented already is because mechanically it's pretty rough.

A rowspan only works if there's no row beneath the one you're spanning,
Without:

A	B	Example time
Lorum	Ipsum	I span one
Lorum	Ipsum	But I already exist

Vs with a span

A	B	Example time
Lorum	Ipsum	I span two
Lorum	Ipsum		But I already exist

So inside the handlebars template, I'd have to somehow backreference the previous row's td in that index to see if it had a rowspan before generating the current row that way I could leave out the specific td, etc. There's a chance some javascript magic could be worked on that table element after it's generated but I've never really given it much thought.

[EddieDover]

Yeah, this would work but we'll have to make it a dual-step process.

The user will need to:

• add {"rowspan":X} to their primary column
• add "type":"span" to their spacer columns

[EddieDover]

So in the example I've been using, if we made the Vision column a rowspan (and moved the content up into it)

{
        "name": "Vision",
        "type": "direct-complex",
        "header": "show",
        "rowspan": 2,
        "text": [
          {
            "type": "exists",
            "value": "system.attributes.senses.darkvision",
            "text": "Darkvision: system.attributes.senses.darkvision"
          },
          {
            "type": "exists",
            "value": "system.attributes.senses.blindsight",
            "text": "Blindsight: system.attributes.senses.blindsight"
          },
          {
            "type": "exists",
            "value": "system.attributes.senses.tremorsense",
            "text": "Tremorsense: system.attributes.senses.tremorsense"
          },
          {
            "type": "exists",
            "value": "system.attributes.senses.truesight",
            "text": "Truesight: system.attributes.senses.truesight"
          },
          {
            "type": "exists",
            "value": "system.attributes.senses.special",
            "text": "Special: system.attributes.senses.special"
          }
        ]
      },

Then we added the new type to the spacer

      {
        "name": "Ins",
        "type": "direct",
        "header": "show",
        "text": "system.skills.ins.passive"
      },
      {
        "name": "Spacer",
        "type": "span",  // <---- here
        "header": "hide",
        "text": ""
      },
      {
        "name": "Status",
        "type": "array-string-builder",
        "align": "left",
        "valign": "top",
        "maxwidth": 70,
        "header": "hide",
        "text": "statuses => value, "
      }

Then the output would look like:

[EddieDover]

Making an Issue from this discussion. Let's continue discussing here, if necessary but you can pull the PR down and test yourself to make things easier.

[dmrickey]

Yeah that output looks great 👍.

(I haven't looked at your changes yet, but it seems like name/header/text wouldn't be needed if type is span)

[EddieDover]

(I haven't looked at your changes yet, but it seems like name/header/text wouldn't be needed if type is span)

Probably, but I'm not sure what will and won't break until I have more time to test, so I just left it in for now. After all these PRs are merged, we'll need to run through the documentation and provide examples / clean things up.