New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractHttpTransport#logRequest always constructs message despite of logging level #248

Open

robotmrv opened this issue Apr 4, 2024 · 0 comments

robotmrv commented Apr 4, 2024

https://github.com/Ecwid/consul-api/blob/232550b44e122f42446876835946baf2de333f53/src/main/java/com/ecwid/consul/transport/AbstractHttpTransport.java#L133C15-L163C25

Since it logs only at finest level it is reasonable to add short cut check for log level before message construction

if (!loger.isLoggable(Level.FINEST)) {
    return;
}

to avoid unnecessary memory allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment