Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be any interest to be able to make a ConsulClient with a given QueryParams and acl token? #218

Open
criverc opened this issue Aug 5, 2021 · 2 comments

Comments

@criverc
Copy link

criverc commented Aug 5, 2021

So that it is not needed to provide them again for every call.
i.e. Instead of doing this:

c = new ConsulClient();
c.getCatalogService(someServiceName, someTag, QueryParams.DEFAULT, someACLToken);

do this:

c = new ConsulClient(QueryParams.DEFAULT, someACLToken);
c.getCatalogService(someServiceName, someTag);

@DanielYWoo
Copy link

Absolutely yes. It will save me a lot of keystrokes.

@DanielYWoo
Copy link

I would like to raise a PR if the maintainers want something like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants