Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie les articles de workspaces par date de mise à jour #1173

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Trie les articles de workspaces par date de mise à jour #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions graphql/resolvers/workspaceResolver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ module.exports = {
* @param {{ loaders: { articles } }} context
* @returns {Promise<*>}
*/
async articles (workspace, _args, context) {
const articles = (await Promise.all(workspace.articles.map((articleId) => context.loaders.articles.load(articleId))))
.filter((a) => a !== undefined) // remove deleted articles
articles.sort((a, b) => a.createdAt > b.createdAt ? -1 : 1)
return Article.complete(articles, context.loaders)
async articles(workspace, _args, context) {
return Article.getArticles({
filter: { _id: { $in: workspace.articles } },
loaders: context.loaders,
})
Comment on lines +122 to +125
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est malin je n'y avais pas pensé 👍🏻
Est-ce qu'il y a une différence notable dans les performances ? Si tu associes plusieurs centaines/milliers d'articles à un espace de travail ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne sais pas, c'est encore mystérieux le fonctionnement des loaders (ça appelle .complete() quand même, donc ça ne change pas grand chose à la précédente manière de faire ?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De prime abord, je dirais que ta solution est plus rapide.
Comme le code est plus simple et que je pense qu'on a assez peu d'espace de travail avec plus de 50 articles on s'en fiche un peu. C'était plus par curiosité 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour les data loaders ça permet de limiter l'effet des requêtes N+1

https://www.apollographql.com/tutorials/dataloaders-dgs/03-data-loaders-under-the-hood

},

async corpus(workspace) {
Expand Down
Loading