String Variables: Operate on Codepoints #3303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code that relies on wchar_t was only activated on Windows because of broken toolchains that lack wchar_t. I reenabled the code now for all platforms. Lets see if it works this time.
This matches the Maniac Patch behaviour better and is actually much better than using bytes. For e.g. Latin1 (Western European) MP works with 1 Byte per char and for shift-jis (Japanese) MP works with multi-byte characters (2 bytes per character). When using Unicode both cases map to 1 codepoint so we are very lucky here: It just works. Fix EasyRPG#3298
27 tasks
fdelapena
approved these changes
Nov 25, 2024
Support left-adjust for PrependMin Support indexing from the back with negative values Fix EasyRPG#3305
|
I handle now the edge cases for out of bounds values. Also supports left-adjust now when "AdjustMin" value is negative and indexing from the back when the index is negative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the test game by @enewey to use extended latin characters like é everywhere:
https://easyrpg.org/play/pr3303/?game=string-var
In UTF-8 they require 2 bytes and 1 codepoint.
Correct is using 1 codepoint here (which matches the legacy encoding = 1 byte)
For あ it is 3 bytes UTF-8 or 1 codepoint. When running in shift-jis RPG_RT seems to use a multibyte character so it also reports 1. There is no shift-jis case in the project but I tested this locally.
Sooo we are just extremely lucky here that it just works even though our encoding is completely different :)