Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the handling of the icon using JavaScript in the slug field #6622

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

javiereguiluz
Copy link
Collaborator

@javiereguiluz javiereguiluz commented Dec 4, 2024

Fixes #6537 (comment)

#SymfonyHackday

@andersonamuller
Copy link
Contributor

andersonamuller commented Dec 5, 2024

Further down is replacing the class of the icon element to switch lock-open/lock, but won't this be a problem with the ux-icons?

https://github.com/EasyCorp/EasyAdminBundle/pull/6622/files#diff-3ad1b42cd463ffe486a9cda065418fd9f0a66e11bad79deba93715c844782a21L107-L118

@javiereguiluz
Copy link
Collaborator Author

@andersonamuller good catch! you are right! I just fixed this during the #SymfonyHackday of the SymfonyCon 2024 Vienna.

@javiereguiluz javiereguiluz merged commit cb9cc4e into EasyCorp:4.x Dec 7, 2024
6 checks passed
@javiereguiluz javiereguiluz deleted the fix_slug_icon branch December 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants