-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of my recommendations for Rosalina #26
Comments
Thank you for these suggestions, I will try to answer these the best I can.
According to the UIToolkit extension code, the
Currently, Rosalina supports editor windows using the
I need time to study this point and try the new runtime binding system.
Good idea, maybe using right-click on a UXML file, and showing a toggle menu item to add/remove the file from the Rosalina's generation system.
Are you talking about the settings file or the "auto genearted" code path ? |
for the last point, sorry for the misunderstanding, I should have made them 2 different points, but basically, it would be nice to choose a custom output path for the auto-generated files, and I feel like it would be better if the Rosalina settings SO was at least moveable so I could put it in a plugins folder, but if that is not possible it would be at least better if it could be put somewhere a user normally wouldn't edit, perhaps in the packages part of the project? |
I understand, in a sense, moving the generated files folder shouldn't be that hard to do. As for the settings, I'll need to do some testing, but I believe it's better to have the settings in a unique place. |
After some tests, I have changed the settings provider mechanism and store the Furthermore, I've started working on the "Manual Generation" system, which allows you to select which UXML you want to include into the automatic generation process. Also, I took the opportunity to include the suggestion made on PR #25 and added the type of generation you want to apply to the document: I could also include the "Custom generation path" within the settings and make the generators use this path instead of a hardcoded one. |
So I have some nitpicks with Rosalina, I am going to be more direct than formal so here they are
Use generics instead of casting
when I checked the generated partial classes, they seemed to be cast instead of being Qed with generics, is there a reason for not using
generics and casting instead? I think generics will help in the long run
Support for Editor Inspectors, Property drawers and etc
as it says, support for these would be helpful
(Maybe?) support for the new runtime binding
unity recently released runtime binding, but it's for the 2023 beta/alpha so it can be delayed, also if it would be better to be done manually, then ignore this point
Manual generation
basically instead of having automatic generation for files, have an option to manually generate for them or select which files to generate specifically (maybe even choosing what kind of generation it is like runtime, editor window, etc)
Custom file path
choosing a custom file path would be a QOL change, also having the Rosalina settings SO be in the packages part would be better if possible
The text was updated successfully, but these errors were encountered: