-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and push manager in demo repo? #100
Comments
In
Each of the "build and push" jobs use the deploy-single-docker-image.yml workflow which has two jobs - "Check for changes" and "Build and push". Check changes uses provided before and after github references to check for changes and see if a rebuild is needed - it is not set to force the rebuild. "Build and push" uses a docker-build-push github action which uses Buildx. One of the steps is to log into DockerHub, could this be why we can't build? Maybe there is some account type we don't have? In the job the option |
Just to see, I tried pulling each of the images that the
I need to investigate that error, but I also want to see if I can run either of the images that pulled. |
At least from everest-demo, we push to the GitHub builtin repo. The |
I have been experimenting with the workflow script for .github/workflows/cicd.yaml, uncommenting the out of use sections to see what errors are present. I have been able to get the portion for mqtt to run, and pushed to my repo without errors. |
Update: manager took about 30 minutes total, but worked without erroring out. I pulled it and it took less than 10 minutes, which seems faster than normal, but I'm not sure what kind of speed we would expect if this work. Got one warning that I still need to investigate, but it still seemed to work.
|
It's still not pushing pre-built images it seems. Running the demo with what I pushed to my repo and what is already in everest-demo is not any faster. I need to dig into the workflow to see what is built and what is pushed. I don't think the manager is built in everest-ci because none of the actions have runtimes long enough if the 30 mins I saw is a decent benchmark. I will bring this up in the FIT group call tomorrow, to see what others think about the problem. It looks like the docker images for EVerest were reworked about 6 months ago, #178, but the proposed changes to the manager were never enacted. |
After the FIT meeting this morning I have a few new leads to try:
It sounds like everest-framework could be the best place to do this, though similar steps may be also possible in everest-demo. When choosing how to implement this, I want to keep in mind the ongoing maintenance to the repository, and ensure that the workflow I choose is reusable and won't fall out of date with the rest of the organization. |
In part to reduce the time it takes to run the demo, we would like to just be able to pull the manager, rather than having to build it from scratch. EVerest ci-cd does build the manager, but it does not push it. Previous attempts to build the manager in github actions ourself has failed. Why does it work for EVerest but not for us? Could EVerest just push the manager after they build it and we could just pull it?
Starting this thread to investigate the existing GitHub Actions, how they work, and if we could expand them ourselves or just leverage the existing processes!
The text was updated successfully, but these errors were encountered: