Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit conversion to DU to recipes that use toz #3784

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Oct 17, 2024

Description

Adapts recipes that use toz in light of ESMValGroup/ESMValCore#2509.

Requires

Note: There are two example recipes that use toz for which we don't need to change anything since they don't have a diagnostic:

https://github.com/ESMValGroup/ESMValTool/blob/main/esmvaltool/recipes/examples/recipe_check_obs.yml


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Oct 17, 2024
@schlunma schlunma added this to the v2.12.0 milestone Oct 17, 2024
@schlunma schlunma requested a review from hb326 October 17, 2024 14:53
@schlunma schlunma self-assigned this Oct 17, 2024
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft PR, Manu, I'll approve and merge once it's RfR )had a look at it already). Also, if we don't measure lengths in alligators, like Muricans do, am not letting this through 🐊 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants