Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Away with netcdftime! #20

Open
hadfieldnz opened this issue Oct 9, 2019 · 1 comment
Open

Away with netcdftime! #20

hadfieldnz opened this issue Oct 9, 2019 · 1 comment

Comments

@hadfieldnz
Copy link
Contributor

In pyroms/pyroms/cf.py on the python3 branch, cftime is imported, with a fallback to netcdftime:

try:
    import cftime
except:
    import netcdftime

This is OK, but later in class time, netcdftime.utime is invoked, which will fail if cftime was successfully imported.

Given that cftime replaced netcdftime in March 2018 and is now available everywhere, I suggest dropping references to netcdftime.

I will prepare a pull request.

@kshedstrom
Copy link
Collaborator

Thank you! I will look into your PR once I'm back in the office next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants