Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Formatter tool for RST files #88

Open
al42and opened this issue Nov 12, 2024 · 2 comments · May be fixed by #92
Open

RFC: Formatter tool for RST files #88

al42and opened this issue Nov 12, 2024 · 2 comments · May be fixed by #92
Assignees

Comments

@al42and
Copy link
Collaborator

al42and commented Nov 12, 2024

docstrfmt and rstfmt can reformat the RST files to make them uniform. This should not affect the rendered result, but should make the source easier to edit and read as a source (uniform line wrapping, indentation, etc).

Since this will generate a large diff, I suggest doing it after the workshop so it does not interfere with any editing activity.

Opening the issue to gauge the interest for this. Please comment if you want to see it implemented or have any opposition to it.

@al42and al42and self-assigned this Nov 12, 2024
@stepas-toliautas
Copy link
Collaborator

On one hand, uniformity would be nice. On the other hand, some other ENCCS lessons tend to mix ReST and Markdown files (because Sphinx-lesson variant allows that); is it possible to treat both adequately, or Markdown files will then be left unedited?

@al42and
Copy link
Collaborator Author

al42and commented Nov 12, 2024

The suggested tools are ReST-only, so they won't touch Markdown. Perhaps there is a single tool to handle both, but I am not aware of such. There are Markdown-specific tols (e.g., https://prettier.io/ -- no endorsement, just a random example).

But I think uniformity among RST files and non-uniformity among MD files is better than non-uniformity everywhere :)

@al42and al42and linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants