Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing literal search #68

Open
mikesname opened this issue Apr 11, 2023 · 5 comments
Open

Failing literal search #68

mikesname opened this issue Apr 11, 2023 · 5 comments
Labels

Comments

@mikesname
Copy link
Contributor

Archives nationales d'outre-mer

Only works when quoted.

@mikesname mikesname added the bug label Apr 11, 2023
@juntezhang
Copy link

You can enable the elision filter to ignore article elisions. This requires a full reindex though for documents that have these tokens.

https://solr.apache.org/guide/solr/latest/indexing-guide/language-analysis.html#french

@mikesname
Copy link
Contributor Author

@juntezhang thanks, I'll check that out! Good to hear from you, hope things are going well in NL.

@mikesname
Copy link
Contributor Author

It turns out that this issue was a bit more straightforward than anticipated, since we already have fields set up with the elision filter for various languages. We just weren't using them in this search 🙍‍♂️.

This probably wouldn't have been noticed, except we added a "mimimum must match" parameter more recently, which in combination the language analysis setting for "generic" text, caused this search to fail.

I have put a fix in place that makes use of the language-aware fields, in addition to some extra testing, and will review at a later date...

@juntezhang
Copy link

juntezhang commented Apr 19, 2023 via email

@mikesname
Copy link
Contributor Author

Yes, way past time we had a proper comprehensive set of search tests, but no-one's had the time yet. I am not alone on this project thankfully (:wave: @mdermentzi @herminiogg ), though I'm responsible for most of the technical debt in this particular area!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants