Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background-image CSS property issue for Defaults and Content Tab #114

Open
serokicki opened this issue Jan 21, 2019 · 2 comments
Open

Background-image CSS property issue for Defaults and Content Tab #114

serokicki opened this issue Jan 21, 2019 · 2 comments

Comments

@serokicki
Copy link

Dear Team,

I have an issue with background-image functionality in EDM editor. Everything started with "Defaults" tab in editor, we found out that using filenames or uri with "()" in filename breaks "preview" of images in editor. This happens because of "not escaping" a uri for a css background-property. Fix was fairly easy - to escape a uri.
Let's say we have a file called: test (1).jpg - this would generate a link like that:
"http://....../Image/136779?path=test%20(1).jpg"
and it won't work because of brackets in it, so to fix this issue i've applied apostrophes to the link:
"'http://....../Image/136779?path=test%20(1).jpg'" it seems that this issue appears in this line of code:
image

But my fix did introduce another issue, where second tab (Content) stopped working because of those apostrophes. Could you please look into this issue?

Thank you in advance.

@gyulanemeth
Copy link
Member

Hello, the problem is that in many cases it's not advised to escape those urls. Can you maybe rename the images?

@agnieszkakowalska
Copy link

Hi Gyula, if these were our images - sure. But we can't control what names client has for their images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants