Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give standalone users a "Shut Up" keybind #197

Open
richardbuckle opened this issue Oct 31, 2017 · 11 comments
Open

Give standalone users a "Shut Up" keybind #197

richardbuckle opened this issue Oct 31, 2017 · 11 comments
Assignees
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. significant work Just sayin' user interface Requires a UI change.

Comments

@richardbuckle
Copy link
Member

While VA users can say "Shut Up" to stop EDDI talking, standalone users have no such option.

Allow standalone users to configure a global keybind to invoke EDDI's ShutUp() function.

Ideally users should be able to define two keybinds, and DirectX inputs such as HOTAS, game pads etc should be available as well as the keyboard.

NB don't make the mistake that Discord did: store the device as well as the button ID. Just because I bound button 9 on my stick doesn't mean that I want button 9 on my throttle bound too ;)

@richardbuckle richardbuckle added the 9. enhancement The behaviour is as specified, but we would like to modify or extend the spec. label Oct 31, 2017
@Tkael Tkael added the user interface Requires a UI change. label Dec 10, 2017
@Tkael
Copy link
Member

Tkael commented Dec 11, 2017

VA users actually have 3 commands that may be relevant here. One to shut EDDI up, one to disable the speech responder, and a third to enable the speech responder. If we take this route, we would probably want to make all three available for keybinding.

@richardbuckle
Copy link
Member Author

I would settle for just the one that means "Shut up what you're saying right now".

@Tkael
Copy link
Member

Tkael commented Jan 8, 2018

I wonder... would fleshing out the script priority system in EDDI accomplish the same purpose in your opinion?

@richardbuckle
Copy link
Member Author

I don’t think it would. The ShupUp() function interrupts EDDI mid-sentence which is not quite the same thing.

@Tkael Tkael added 8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. and removed 9. enhancement The behaviour is as specified, but we would like to modify or extend the spec. labels Jan 12, 2018
@Tkael
Copy link
Member

Tkael commented Mar 20, 2018

The SharpDX library (or similar) looks like it will be needed for DirectX inputs. http://sharpdx.org/

@richardbuckle
Copy link
Member Author

Good find. Let’s also ask the other EDCD folks for recommendations.

@richardbuckle richardbuckle added this to the 3.0.2 milestone Jun 28, 2018
@richardbuckle richardbuckle added 5. painful Something is not fit for purpose but there is a workaround. and removed 8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. labels Jun 28, 2018
@Tkael Tkael modified the milestones: 3.0.2, 3.1 Aug 19, 2018
@Hoodathunk Hoodathunk modified the milestones: 3.1, 3.2 Oct 15, 2018
@Tkael Tkael added 8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. and removed 5. painful Something is not fit for purpose but there is a workaround. labels Feb 9, 2019
@richardbuckle richardbuckle removed this from the 3.2 milestone Mar 9, 2019
@richardbuckle
Copy link
Member Author

I'd be happy with just a customisable keyboard input for a first iteration. We can look at DirectX later.

@shodanx2
Copy link

Hello,
This issue is probably making most EDDI users just disable all text to voice on their first session.
How does VA tell EDDI to "shutup" ?
Surely that can be emulated with random hotkey software like AutoIT ?

Or maybe from a command line like EDDI.exe -shutup and just invoke that from AutoIT.

@Tkael
Copy link
Member

Tkael commented Apr 10, 2022

At the moment, it is not possible to do this from either a hotkey or from the command line. The VoiceAttack plugin command directly invokes a method in the SpeechService class.

/// <summary>
/// Stop talking
/// </summary>
public static void InvokeShutUp(ref dynamic vaProxy)
{
try
{
SpeechService.Instance.ShutUp();
SpeechService.Instance.StopAudio();
}
catch (Exception e)
{
setStatus(ref vaProxy, "Failed to shut up", e);
}
}

@shodanx2
Copy link

Could AutoIT be used to trigger this ?
I just started playing ED, first thing I did after re-installing EDDI is turn off text to speech
Which is a shame because I would like it.
But I can't wait for it to shut up if I need to talk to my friend or if they're talking to me.

@Tkael
Copy link
Member

Tkael commented Sep 12, 2022

Not that I'm aware of (I don't use AutoIT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8. annoyance The behaviour is as specified, but has been found to be annoying in practice by real-world users. significant work Just sayin' user interface Requires a UI change.
Projects
None yet
Development

No branches or pull requests

4 participants