Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review - Documentation #92

Open
jwagemann opened this issue Aug 6, 2019 · 2 comments
Open

Review - Documentation #92

jwagemann opened this issue Aug 6, 2019 · 2 comments
Labels

Comments

@jwagemann
Copy link
Contributor

  • We see you plan to document functions using sphinx, it would be good to have some basic doc files already

  • Notebooks are barely commented, could you please expand on the reasons behind the different steps? Ideally, each notebook should be self explanatory (like a stand-alone tutorial).

@tommylees112
Copy link
Contributor

Which notebooks are you referring to?

The notebooks in notebooks/draft are more for internal visualisations and testing the use of the pipeline.

Are the notebooks in notebooks/docs better commented?

@tommylees112
Copy link
Contributor

tommylees112 commented Aug 12, 2019

We see you plan to document functions using sphinx, it would be good to have some basic doc files already

Please see the branch: docs/sphinx. We’ve done our best to ensure all the classes and functions which we intend to expose have good docstrings, so a lot of the functionality can be exposed using the help function.

In addition, the major steps of the pipeline - and the appropriate code to run them - is in the scripts directory, along with an accompanying readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants