From 2f889826f61dc9a9c8a66c6ec76333384ddbae48 Mon Sep 17 00:00:00 2001 From: tcezard Date: Tue, 1 Oct 2024 11:21:49 +0100 Subject: [PATCH] Address review comments --- .github/workflows/build.yml | 1 - CMakeLists.txt | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 80bd65e7..dec036de 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -125,7 +125,6 @@ jobs: - name: Compile and test run: | mkdir build && cd build && cmake -G "Unix Makefiles" -DCMAKE_CXX_COMPILER=${{ matrix.config.cxx }} -DCMAKE_C_COMPILER=${{ matrix.config.cc }} .. - export LIBRARY_PATH=${LIBRARY_PATH}:/opt/homebrew/opt/icu4c/lib:/opt/homebrew/lib make -j2 cd .. && ./build/bin/test_validation_suite - name: Rename release files diff --git a/CMakeLists.txt b/CMakeLists.txt index 86a49828..0bf06e15 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -87,7 +87,7 @@ if (LINUX) elseif (OSX) # Mac build not fully static. include system libraries to be dynamic set (CMAKE_EXE_LINKER_FLAGS) - set (Boost_USE_STATIC_LIBS OFF) # only find static libs + set (Boost_USE_STATIC_LIBS OFF) # use dynamically linked libraries elseif (WINDOWS) set (Boost_USE_STATIC_LIBS ON) # only find static libs set (CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT") # also requires boost with runtime-link=static