You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR#83 is still missing the sourceUrl attribute to be filled in.
Seems like it is not straightforward, because this will require some communication between different classes to pass the source url from the Datasource class (in which we download the assembly report) all the way to the metadata class (or to the service that will populate it).
For example, we might need to change the return type of this method, in order to let it pass the sourceUrl along with the Path:
Note: we might find a better way of passing this information without the need for a refactor, maybe writing into a shared synchronized stack, queue, file, etc.. Still not sure about that.
I've made a separate issue because it might be better to fix and discuss it in a different PR.
The text was updated successfully, but these errors were encountered:
PR#83 is still missing the
sourceUrl
attribute to be filled in.Seems like it is not straightforward, because this will require some communication between different classes to pass the source url from the Datasource class (in which we download the assembly report) all the way to the metadata class (or to the service that will populate it).
For example, we might need to change the return type of this method, in order to let it pass the sourceUrl along with the Path:
Note: we might find a better way of passing this information without the need for a refactor, maybe writing into a shared synchronized stack, queue, file, etc.. Still not sure about that.
I've made a separate issue because it might be better to fix and discuss it in a different PR.
The text was updated successfully, but these errors were encountered: