Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVA-3425 make sure reference and alternate is always upper case #192

Merged
merged 3 commits into from
Oct 26, 2023
Merged

EVA-3425 make sure reference and alternate is always upper case #192

merged 3 commits into from
Oct 26, 2023

Conversation

nitin-ebi
Copy link
Contributor

No description provided.

@nitin-ebi nitin-ebi self-assigned this Oct 16, 2023
sundarvenkata-EBI
sundarvenkata-EBI reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@sundarvenkata-EBI sundarvenkata-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we might need to write explicit tests given that we are modifying something very fundamental...

@nitin-ebi nitin-ebi merged commit e027cbc into EBIvariation:master Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundarvenkata-EBI sundarvenkata-EBI sundarvenkata-EBI approved these changes

@tcezard tcezard tcezard approved these changes

Assignees

@nitin-ebi nitin-ebi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitin-ebi @tcezard @sundarvenkata-EBI