Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be an error if RestartRead is not present in omega.yml? #175

Closed
xylar opened this issue Dec 2, 2024 · 2 comments · Fixed by #184
Closed

Should it be an error if RestartRead is not present in omega.yml? #175

xylar opened this issue Dec 2, 2024 · 2 comments · Fixed by #184
Assignees
Labels
question Further information is requested

Comments

@xylar
Copy link

xylar commented Dec 2, 2024

I got an error when RestartRead was not present in omega.yml. For most Polaris tests, we don't anticipate needing a restart. It's not a problem to include a RestartRead entry in the IOStreams but I wanted to make sure that the requirement that it be there is intentional.

@xylar xylar added the question Further information is requested label Dec 2, 2024
@philipwjones
Copy link

Didn't think about the case where the entry isn't needed and is missing so I guess I need to catch that while still making sure the state is initialized. Are you initializing with the InitialState in these cases or will there be cases where we will initialize a test case with internal analytical data without reading one of those two streams?

@xylar
Copy link
Author

xylar commented Dec 3, 2024

We always initialize with InitialState whenever we wouldn't be using RestartRead. I don't think we plan to initialize from an analytic initial condition in Omega itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants