Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] increase limits for load tests #400

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Dec 6, 2024

According to the recent results https://dynatrace.github.io/dynatrace-otel-collector/benchmarks/loadtests/ there was no significant or sudden increase in the memory consumption, but it was always rather close to the specified limits

Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl marked this pull request as ready for review December 6, 2024 07:36
@bacherfl bacherfl requested a review from a team as a code owner December 6, 2024 07:36
@pirgeo
Copy link
Contributor

pirgeo commented Dec 6, 2024

Do you think it makes sense to add the maximum specified for the test into the graphs as well? So we can see how close we are to hitting the cutoff point?

@bacherfl
Copy link
Contributor Author

bacherfl commented Dec 6, 2024

Do you think it makes sense to add the maximum specified for the test into the graphs as well? So we can see how close we are to hitting the cutoff point?

that's a good idea - I'd look into that in a separate PR, as I need to figure out how to best get this data into the result json file generated by the testing library

@pirgeo
Copy link
Contributor

pirgeo commented Dec 6, 2024

Sounds good, definitely should go in a separate PR. Since you mentioned "we've been pretty close to the limits" I looked at the overview page and realized I have no idea what the limits actually are 😄

@bacherfl bacherfl merged commit 2707a57 into main Dec 6, 2024
19 checks passed
@bacherfl bacherfl deleted the chore-adapt-load-test-limits branch December 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants