Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYN-6353] Fix SignIn button title to reflect correct status when user is already signed in #42

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[DYN-6353] Fix SignIn button title to reflect correct status when user is already signed in #42

merged 2 commits into from
Oct 23, 2023

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Oct 23, 2023 •
edited
Loading

Fix a regression from previous PR.
Changing the variable source from props, to state, where it is being updated.

ezgif com-crop

@QilongTang QilongTang merged commit 007be47 into master Oct 23, 2023
11 checks passed
@QilongTang QilongTang deleted the fix-signin-btn branch October 23, 2023 20:42
@QilongTang
Copy link
Contributor

QilongTang commented Oct 23, 2023 •
edited
Loading

hi @zeusongit Would you draft a new Github release with this?

@zeusongit
Copy link
Contributor Author

@QilongTang Done: https://github.com/DynamoDS/SplashScreen/releases/tag/v1.0.11

@mjkkirschner
Copy link
Member

tests? The current tests in this repo look "minimal".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeusongit @QilongTang @mjkkirschner