Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version selector #2064

Open
wants to merge 4 commits into
base: Revit2018
Choose a base branch
from

Conversation

chtimi59
Copy link

@chtimi59 chtimi59 commented Jun 5, 2018

Purpose

Problem to solve:

  • As a user, if multiple DynamoRevit version is installed, then it's quite annoying to keep selecting version on each Revit session.
  • If a Revit's addin is based on DynamoRevit, but if multiple versions are installed, then there is no technical solution to provide a good user experience in this new addin.

Proposal:

  • If a unique DynamoRevit product is installed, then the behavior do not change
  • If multiple DynamoRevit product are installed, then the behavior do not change neither except a new Icon what appears in the Ribbon:
    image
    which brings the following version picker dialog
    image
    When user selects one those version, the choice is persisted (and may required a Revit restart).

Note1: The default behavior is "None" (which is current behavior of master branch)

Note2: If the latest version is selected then it will still be the case if new installation occurs after

Declarations

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Tests

Test made by using Revit 2018, with addition DynamoRevit 2.0.1 installation

@chtimi59 chtimi59 changed the title proposal New version selector by chtimi59 Jun 5, 2018
@chtimi59 chtimi59 changed the title New version selector by chtimi59 New version selector Jun 5, 2018
@Dewb
Copy link

Dewb commented Jun 7, 2018

This approach probably needs to be validated with Revit PMs. I suspect this would be an improvement for most users, but for any users that need to switch back and forth on a per-project basis, this might be a worse experience. Perhaps something like a settings flyout on the ribbon pane with the choice between a) "Latest Version", b) "Specific Version" (with a list to pick from), or c) "Ask every time" would be a better compromise. (If only one version was installed, that version would be launched regardless of the choice.)

@chtimi59
Copy link
Author

Hi @Dewb, thanks for comment,
Here is a little update, to target your point. Technically I bring back the previous behavior under a "None" option if user click on "Version Selection" (see PR Description). Please notice that the "None" option is the actual default option. In other words, by default the user experience is exactly the same as now.

@chtimi59
Copy link
Author

chtimi59 commented Jun 12, 2018

Tests made: test.xlsx

@CSFitzgerald
Copy link

@Dewb, to the best of my understanding - Dynamo only asks you which version you would like to open when you open Dynamo for the first time on a current Revit session. Starting a new project does not bring back the version selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants