Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for multiply (R←X×Y) #76

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Tests for multiply (R←X×Y) #76

wants to merge 24 commits into from

Conversation

sloorush
Copy link
Member

@sloorush sloorush commented Aug 9, 2024

@sloorush sloorush marked this pull request as draft August 9, 2024 10:06
@sloorush sloorush marked this pull request as ready for review September 2, 2024 13:30
@sloorush sloorush requested review from pmikkelsen and removed request for pmikkelsen November 21, 2024 18:59
@sloorush
Copy link
Member Author

sloorush commented Nov 26, 2024

Todo:

  • fix cases with model not working with complex multiplication of the order 1E10 J 1E10

@sloorush sloorush requested a review from pmikkelsen November 26, 2024 15:36
@sloorush
Copy link
Member Author

@pmikkelsen @definitelyprobably This PR is ready for review. Please LMK what you think about it and if I have missed anything. Thanks

Note: I have skipped ⎕FR←1287 for Hcmplx because the model is not appropriate for it. I had a chat with @pmikkelsen about it and we decided it is better to skip it.

Copy link
Collaborator

@pmikkelsen pmikkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

readme.md Outdated Show resolved Hide resolved
tests/multiply.apln Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for Multiply (X×Y)
2 participants