-
Notifications
You must be signed in to change notification settings - Fork 14
Serialize a blob into an existing collation body. #78
Comments
@tcsiwula or @samparsky, would you like to have a go at this? |
Yeah, me pretty please! |
Great, let me know if you need any help. Keep a log of your time. |
Sounds good @jamesray1 . FYI, I was just pulling/merging in your latest changes from your develop branch. Very big!
|
Yeah I saw that as well a while back, although I don't know why rls/debug/deps/libsyntex_syntax-189bf668f45d362c.rlib is so big, and I'm not sure if we need it in the repo. I'll add it to .gitignore. |
Ah rls/debug/deps/libsyntex_syntax-189bf668f45d362c.rlib is already in .gitignore (included as part of /rls/), so I'm not sure why you got that error. |
Is your local .gitignore file the same as the upstream one? |
I have this one:
I think that directories have no So maybe (mAyBe!) this
should be just this
|
You're right, otherwise |
Please give me your Github no-reply email address for https://blog.github.com/2018-01-29-commit-together-with-co-authors/. |
Changed gitignore with #81. |
We should look into using protobuf, it seems like a better alternative: https://ethresear.ch/t/blob-serialisation/1705/23?u=jamesray1. |
I have heard of protobuf, seems legit. Will look into more. I read rust/cargo also has a good profiler tool that can analyze memory usage. |
For details, see:
https://github.com/Drops-of-Diamond/diamond_drops/blob/develop/node/src/modules/collation/blob.rs#L195-L202
The text was updated successfully, but these errors were encountered: