From fd114c1e40426d438b469b8d9831814747ef579b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn?= Date: Fri, 8 Sep 2023 18:52:14 +0200 Subject: [PATCH] Generalized triggerDescriptorUpdate manipulation to multiple ReportParts. (#64) In order to Fix a Defect in SDCcc's Test case for Biceps:R5025, I had to generalize this Manipulation. # Checklist The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee **and** reviewer: * Changelog update (necessity checked and entry added or not added respectively) * [x] Pull Request Assignee * [x] Reviewer * README update (necessity checked and entry added or not added respectively) * [x] Pull Request Assignee * [x] Reviewer --------- Co-authored-by: Lukas Deichmann <8513777+ldeichmann@users.noreply.github.com> Co-authored-by: Maximilian Pilz --- CHANGELOG.md | 1 + src/t2iapi/device/device_requests.proto | 14 ++++++++++++++ src/t2iapi/device/service.proto | 13 +++++++++---- 3 files changed, 24 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 282eebb..62f9124 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 SetMetricValuesWithQualityMode - semantics for SetDeviceOperatingMode manipulation - message PartialIdentification to message PartialInstanceIdentifier +- TriggerDescriptorUpdate to request an update for an arbitrary amount of handles ### Removed diff --git a/src/t2iapi/device/device_requests.proto b/src/t2iapi/device/device_requests.proto index 28fa67d..6204c80 100644 --- a/src/t2iapi/device/device_requests.proto +++ b/src/t2iapi/device/device_requests.proto @@ -51,3 +51,17 @@ message SetBatteryUsageRequest { // electrical power source bool use = 2; // specifies whether the battery shall be used as the electrical power source } + +/* +Request a DescriptionModificationReport that fulfills the following: + +For each given handle there exists an "Upt"-ReportPart that contains an updated descriptor, whose @DescriptorHandle +is equal to the given handle, and that is contained in the DescriptionModificationReport. + +--- + +Note that when no handle is given, every DescriptionModificationReport fulfills the request. +*/ +message TriggerDescriptorUpdateRequest{ + repeated string handle = 1; +} diff --git a/src/t2iapi/device/service.proto b/src/t2iapi/device/service.proto index 393ee4c..806f1c1 100644 --- a/src/t2iapi/device/service.proto +++ b/src/t2iapi/device/service.proto @@ -89,11 +89,16 @@ service DeviceService { rpc RemoveMdsDescriptor (BasicHandleRequest) returns (BasicResponse); /* - Trigger a descriptor update for the provided handle. - This manipulation of the device shall result in a msg:DescriptionModificationReport message with a report part with - modification type upt. + Trigger a DescriptionManipulationReport that fulfills the following: + + For each given handle there exists an "Upt"-ReportPart that contains an updated descriptor, whose @DescriptorHandle + is equal to the given handle, and that is contained in the DescriptionModificationReport. + + --- + + Note that when no handle is given, every DescriptionModificationReport fulfills the request. */ - rpc TriggerDescriptorUpdate (BasicHandleRequest) returns (BasicResponse); + rpc TriggerDescriptorUpdate (TriggerDescriptorUpdateRequest) returns (BasicResponse); /* Trigger a descriptor update.