From 50bc949502d7fc7a54937596875fca0982eb8f6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Engelmann?= Date: Mon, 7 Oct 2024 12:15:09 +0200 Subject: [PATCH] Changes proposed by Reviewers. --- src/t2iapi/device/device_responses.proto | 4 ++-- src/t2iapi/device/service.proto | 12 ++++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/t2iapi/device/device_responses.proto b/src/t2iapi/device/device_responses.proto index 493e105..c5b7031 100644 --- a/src/t2iapi/device/device_responses.proto +++ b/src/t2iapi/device/device_responses.proto @@ -87,6 +87,6 @@ Response containing the @MdibVersion from which on the requested change will be */ message MdibVersionResponse { BasicResponse status = 1; // status of the rpc - string sequence_id = 2; // SequenceId of MdibVersion. - int64 mdib_version = 3; // Mdib Version from which on the change will be effective. + string sequence_id = 2; // @SequenceId of Mdib. + int64 mdib_version = 3; // @MdibVersion from which on the change will be effective. } diff --git a/src/t2iapi/device/service.proto b/src/t2iapi/device/service.proto index 8fc8b04..9b64746 100644 --- a/src/t2iapi/device/service.proto +++ b/src/t2iapi/device/service.proto @@ -231,16 +231,20 @@ service DeviceService { returns (TrueFalseResponse); /* - Physically disconnect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays disconnected - at least until the next manipulation call. + Physically disconnect the REMOVABLE SUBSYSTEM (as defined in IEEE Std 11073-10700-2022) + represented by the given descriptor. The manipulated state shall be persistent until a + next manipulation call. If the device is not able to maintain the static state, + it shall return RESULT_NOT_SUPPORTED. Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is disconnected. */ rpc DisconnectRemovableSubsystem(BasicHandleRequest) returns (MdibVersionResponse); /* - Physically connect the REMOVABLE SUBSYSTEM represented by the given descriptor. Ensure that it stays connected - at least until the next manipulation call. + Physically connect the REMOVABLE SUBSYSTEM (as defined in IEEE Std 11073-10700-2022) + represented by the given descriptor. The manipulated state shall be persistent until a + next manipulation call. If the device is not able to maintain the static state, + it shall return RESULT_NOT_SUPPORTED. Returns the mdib version starting from which the REMOVABLE SUBSYSTEM is connected. */ rpc ConnectRemovableSubsystem(BasicHandleRequest)