Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The config option SDCcc.TLS.EnabledProtocols is never applied #133

Closed
maximilianpilz opened this issue Jan 10, 2024 · 0 comments · Fixed by #139
Closed

The config option SDCcc.TLS.EnabledProtocols is never applied #133

maximilianpilz opened this issue Jan 10, 2024 · 0 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@maximilianpilz
Copy link
Collaborator

SDCcc.TLS.EnabledProtocols in the config is read in, but not actually applied and thus the default of [TLSv1.2, TLSv1.3] is always used no matter what the user provides via SDCcc.TLS.EnabledProtocols .
@maximilianpilz maximilianpilz added the bug Something isn't working label Jan 10, 2024
@maximilianpilz maximilianpilz linked a pull request Feb 23, 2024 that will close this issue
Fix the tls version parameter and add a cipher parameter #139
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the tls version parameter and add a cipher parameter maximilianpilz/SDCcc
1 participant
@maximilianpilz