Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why tweet_status_id_str on EntryVersion and not Diff? #80

Open
edsu opened this issue May 9, 2020 · 1 comment
Open

Why tweet_status_id_str on EntryVersion and not Diff? #80

edsu opened this issue May 9, 2020 · 1 comment

Comments

@edsu
Copy link
Member

edsu commented May 9, 2020 •
edited
Loading

Since diffs are tweeted and not particular versions I'm wondering why we are storing the tweet id for the diff on the EntryVersion instead of Diff? I think it would be cleaner to store it on the Diff right?
@edsu edsu assigned edsu and unassigned edsu May 9, 2020
@nahuelhds
Copy link
Contributor

This was done this way for easy threading. I asked the same myself and I even try go that path but implied a little rework that I didn't want to face on that stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsu @nahuelhds