From f55686beba07bb62e033a3dd22c5de2907d2ea0a Mon Sep 17 00:00:00 2001
From: Dmitry Stroganov <dmst@simcorp.com>
Date: Wed, 6 Mar 2019 09:12:25 +0100
Subject: [PATCH] tests slight cleanup

---
 Source/SdkTests/MeetingTests.cs       |  2 +-
 Source/SdkTests/ReportingTests.cs     | 50 +++------------------------
 Source/SdkTests/SdkTests.csproj       |  1 +
 Source/SdkTests/XmlSerializerTests.cs | 50 +++++++++++++++++++++++++++
 4 files changed, 56 insertions(+), 47 deletions(-)
 create mode 100644 Source/SdkTests/XmlSerializerTests.cs

diff --git a/Source/SdkTests/MeetingTests.cs b/Source/SdkTests/MeetingTests.cs
index eae919f..78ad688 100644
--- a/Source/SdkTests/MeetingTests.cs
+++ b/Source/SdkTests/MeetingTests.cs
@@ -29,7 +29,7 @@ public void GetMyMeetings()
     [TestMethod]
     public void GetSCOshotcuts()
     {
-      var result = MeetingManagement.GetSCOshotcuts(this.Api);
+      var result = MeetingManagement.GetSCOshortcuts(this.Api);
       Assert.IsTrue(result.Result.Any());
     }
 
diff --git a/Source/SdkTests/ReportingTests.cs b/Source/SdkTests/ReportingTests.cs
index a7c2325..63db98b 100644
--- a/Source/SdkTests/ReportingTests.cs
+++ b/Source/SdkTests/ReportingTests.cs
@@ -1,55 +1,13 @@
 namespace SdkTests
 {
-  using System;
-  using AdobeConnectSDK;
-  using AdobeConnectSDK.Common;
-  using AdobeConnectSDK.Extensions;
-  using AdobeConnectSDK.Model;
-  using Microsoft.VisualStudio.TestTools.UnitTesting;
-  using SdkTests.Common;
-  using System.Collections.Generic;
-  using System.Linq;
+    using AdobeConnectSDK.Extensions;
+    using Microsoft.VisualStudio.TestTools.UnitTesting;
+    using SdkTests.Common;
+    using System.Linq;
 
   [TestClass]
   public class ReportingTests : TestsBase
   {
-    [TestMethod]
-    public void QuotaEntity_CanSerializeAndDeserialize()
-    {
-      QuotaInfo qi = new QuotaInfo()
-      {
-        QuotaList = new List<Quota> { 
-          new Quota { AclId = 1, Limit = 2, QuotaId = "tstquota", SoftLimit = 4, Used = 5 },
-          new Quota { AclId = 5, Limit = 6, QuotaId = "tstquota2", SoftLimit = 7, Used = 8 } 
-        }
-      };
-
-      string s = XmlSerializerHelpersGeneric.ToXML(qi);
-
-      QuotaInfo r = XmlSerializerHelpersGeneric.FromXML<QuotaInfo>(s);
-
-      Assert.AreEqual(qi.QuotaList.First().AclId, r.QuotaList.First().AclId);
-    }
-
-    [TestMethod]
-    public void QuotaEntity_CanDeserialize()
-    {
-      QuotaInfo qi = new QuotaInfo()
-      {
-        QuotaList = new List<Quota> { 
-          new Quota { AclId = 838570243, Limit = 2, QuotaId = "tstquota", SoftLimit = 4, Used = 5, DateBegin = new DateTime(2009, 03, 31, 08, 07, 59, 180, DateTimeKind.Utc) },
-          new Quota { AclId = 5, Limit = 6, QuotaId = "tstquota2", SoftLimit = 7, Used = 8 } 
-        }
-      };
-
-      string s = "<report-quotas> <quota acl-id=\"838570243\" quota-id=\"download-quota\" used=\"0\" limit=\"10\" soft-limit=\"10\">  <date-begin>2009-03-31T10:07:59.180+02:00</date-begin>   <date-end>3000-01-01T01:00:00.537+01:00</date-end>   </quota></report-quotas>";
-
-      QuotaInfo r = XmlSerializerHelpersGeneric.FromXML<QuotaInfo>(s);
-
-      Assert.AreEqual(qi.QuotaList.First().AclId, r.QuotaList.First().AclId);
-      Assert.AreEqual(qi.QuotaList.First().DateBegin, r.QuotaList.First().DateBegin);
-    }
-
     [TestMethod]
     public void Report_Quotas()
     {
diff --git a/Source/SdkTests/SdkTests.csproj b/Source/SdkTests/SdkTests.csproj
index cb16393..5626ba1 100644
--- a/Source/SdkTests/SdkTests.csproj
+++ b/Source/SdkTests/SdkTests.csproj
@@ -63,6 +63,7 @@
     <Compile Include="MeetingTests.cs" />
     <Compile Include="ScenarioTests.cs" />
     <Compile Include="UserAccountTests.cs" />
+    <Compile Include="XmlSerializerTests.cs" />
   </ItemGroup>
   <ItemGroup>
     <EmbeddedResource Include="Resources\report-quotas.xml">
diff --git a/Source/SdkTests/XmlSerializerTests.cs b/Source/SdkTests/XmlSerializerTests.cs
new file mode 100644
index 0000000..8649842
--- /dev/null
+++ b/Source/SdkTests/XmlSerializerTests.cs
@@ -0,0 +1,50 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using AdobeConnectSDK.Common;
+using AdobeConnectSDK.Model;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace SdkTests
+{
+    //TODO: implement tests for all data models
+    [TestClass, Ignore]
+    public class XmlSerializerTests
+    {
+        [TestMethod]
+        public void QuotaEntity_CanSerializeAndDeserialize()
+        {
+            QuotaInfo qi = new QuotaInfo() {
+                QuotaList = new List<Quota> {
+                    new Quota { AclId = 1, Limit = 2, QuotaId = "tstquota", SoftLimit = 4, Used = 5 },
+                    new Quota { AclId = 5, Limit = 6, QuotaId = "tstquota2", SoftLimit = 7, Used = 8 }
+                }
+            };
+
+            string s = XmlSerializerHelpersGeneric.ToXML(qi);
+
+            QuotaInfo r = XmlSerializerHelpersGeneric.FromXML<QuotaInfo>(s);
+
+            Assert.AreEqual(qi.QuotaList.First().AclId, r.QuotaList.First().AclId);
+        }
+
+        [TestMethod]
+        public void QuotaEntity_CanDeserialize()
+        {
+            QuotaInfo qi = new QuotaInfo() {
+                QuotaList = new List<Quota> {
+                    new Quota { AclId = 838570243, Limit = 2, QuotaId = "tstquota", SoftLimit = 4, Used = 5, DateBegin = new DateTime(2009, 03, 31, 08, 07, 59, 180, DateTimeKind.Utc) },
+                    new Quota { AclId = 5, Limit = 6, QuotaId = "tstquota2", SoftLimit = 7, Used = 8 }
+                }
+            };
+
+            string s =
+                "<report-quotas> <quota acl-id=\"838570243\" quota-id=\"download-quota\" used=\"0\" limit=\"10\" soft-limit=\"10\">  <date-begin>2009-03-31T10:07:59.180+02:00</date-begin>   <date-end>3000-01-01T01:00:00.537+01:00</date-end>   </quota></report-quotas>";
+
+            QuotaInfo r = XmlSerializerHelpersGeneric.FromXML<QuotaInfo>(s);
+
+            Assert.AreEqual(qi.QuotaList.First().AclId, r.QuotaList.First().AclId);
+            Assert.AreEqual(qi.QuotaList.First().DateBegin, r.QuotaList.First().DateBegin);
+        }
+    }
+}