Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage removal of Prefs that are unused #659

Closed
windymilla opened this issue Jan 12, 2025 · 0 comments · Fixed by #662
Closed

Manage removal of Prefs that are unused #659

windymilla opened this issue Jan 12, 2025 · 0 comments · Fixed by #662
Assignees
Labels
code improvement Improve maintainability, consistency, etc

Comments

@windymilla
Copy link
Collaborator

windymilla commented Jan 12, 2025

If a pref is removed in a release, then when the user first runs the new release they may get a warning about an unknown pref.

Options:

  1. Make the warning only visible for devs/debug or something similar (like assert), so it doesn't confuse regular users (maybe this or this )
  2. Don't remove prefs, just make them unused, so they can still be read from a Prefs file without errors. Every so often, you could clear that list, once people have had a chance to pass run the release without the pref, so their prefs file won't contain the old pref any more.
  3. Try this first: wrap assertion in try/except, and output the warning in the exception code.
@windymilla windymilla added the code improvement Improve maintainability, consistency, etc label Jan 12, 2025
@windymilla windymilla self-assigned this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement Improve maintainability, consistency, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant