Lower priority of SPOTLIGHT highlight tag #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional note to avoid confusion: the cursor disappearing is normal; that is not changed by this PR. Only the visibility of what text is selected has changed. |
srjfoo
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing notes:
Load a file and run a WF check, e.g. hyphens (as noted in the original ticket). Clicking on a match will take you to that text in the file and highlight with SPOTLIGHT (e.g. orange background in light theme). Select one or more characters in the text. On the master branch, the cursor disappears and you can't see what's selected. On this branch, you can see what you've selected. (Should be the same if you select with keyboard or mouse.)
Fixes #631