Fix redraw handling (regression bug) #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DistributedProofreaders#238, binding of button-1 (left-click) created a regression that didn't fire redraws on click properly. Fixes DistributedProofreaders#613
|
Testing notes: Click in the file to move the cursor (and do nothing else). The line & column ruler should update. If quotes/brackets mode is turned on, those highlights should also update. Without this patch applied, clicking doesn't redraw properly. You have to move with the arrow keys or scroll or take some other action than clicking in order to trigger a redraw. |
|
It's probably also worth re-testing that select-dragging past the window edge still works like it should, too. |
srjfoo
approved these changes
Dec 29, 2024
windymilla
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #238, binding of button-1 (left-click) created a regression that didn't fire redraws on click properly.
Fixes #613