Split checker dialogs so they all get their own settings #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledhelix
approved these changes
Dec 30, 2024
In preparation for more checker-specific behavior This makes each checker dialog store its own geometry.
Suspects-only and Sort method are now stored for each checker dialog.
windymilla
force-pushed
the
per-dialog-settings
branch
from
9070d59 to
66b28fb
Compare
srjfoo
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common settings (sorting method and suspects-only) and geometry (position & size) used to be shared amongst most checker dialogs, e.g. Search and Footnote Fixup. There were a few exceptions, like Find All.
They should all now be individual to the dialog, so you can position each one where you like, make it an appropriate width for the type of messages it shows, turn on/off suspects-only, and change the sort method without affecting the other dialogs.
Testing notes: Illo Fixup and Sidenote Fixup were previously very closely linked and shared their data, so needed extra work to extricate them, so please especially check they are working independently of one another.