Detect ditto marks better in curly quotes #590
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only quotes that had 2 spaces either side were converted to ditto marks. Double quotes are now interpreted as ditto marks if they are at start of line (with optional space before) and have 2 spaces after, or if they are at end of line (with optional space after) and have 2 spaces before. This compromise is to try to detect ditto marks without letting badly spaced quotes pass by undetected, hence the requirement for a double space before/after/
|
Fixes #586 |
|
Testing notes: Linked issue has this file: https://github.com/user-attachments/files/18204548/belgian.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only quotes that had 2 spaces either side were converted to ditto marks. Double quotes are now
interpreted as ditto marks if they are at start of line (with optional space before) and have 2 spaces after, or if they are at end of line (with optional space after) and have 2 spaces before.
This compromise is to try to detect ditto marks without letting badly spaced quotes pass by undetected, hence the requirement for a double space before/after/