Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement active/inactive highlight during a Search #564

Open
tangledhelix opened this issue Dec 5, 2024 · 0 comments
Open

Implement active/inactive highlight during a Search #564

tangledhelix opened this issue Dec 5, 2024 · 0 comments
Assignees
Labels
future feature New feature or request, but not core

Comments

@tangledhelix
Copy link
Collaborator

As discussed in #561.

Currently when you search (and use next/prev...) the currently focused match is highlighted as you navigate from one match to the next. Other matches, even if they are within the viewport, are treated as normal text and not highlighted.

Leave the currently focused match as-is. Implement a noticeable but de-emphasized highlight on other matches which fall into the viewport. Matches outside the viewport should probably not be considered, to avoid searching the entire file repeatedly. Implement something to run in on_change to reconsider / rehighlight the viewport rather than try to highlight the entire file, which can be too slow.

@tangledhelix tangledhelix added the future feature New feature or request, but not core label Dec 5, 2024
@tangledhelix tangledhelix self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future feature New feature or request, but not core
Projects
None yet
Development

No branches or pull requests

1 participant