Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Check does not work like GG1 #343

Closed
okrick opened this issue Jul 28, 2024 · 3 comments · Fixed by #355
Closed

Spell Check does not work like GG1 #343

okrick opened this issue Jul 28, 2024 · 3 comments · Fixed by #355
Labels
core feature Required for basic PPing

Comments

@okrick
Copy link

okrick commented Jul 28, 2024

  1. GG2 spell check examines the entire document, even when only a portion is selected, unlike GG1 which checks only the selected text.

  2. Unlike GG1's popup, GG2 presents a full list of misspelled words in a new window, similar to the Word Frequency -> Check Spelling function.

  3. GG2 lists every occurrence of a misspelled word, for instance, showing all 1647 appearances of "png" separately. This differs from GG1, which displays each word once with its total count. The extensive GG2 list (20,352 entries) is overwhelming compared to GG1's slightly more manageable list of 10,215 unique words.

  4. If emulating Word Frequency -> Spelling Check, GG2 should allow sorting by word frequency and length. Longer words often have more spelling errors. Additionally, ignoring frequently misspelled words can be helpful, assuming they are intentional style choices.

  5. The GG1 Spell Check "Add Goodwords to Proj. Dictionary" functionality should be replicated in GG2.

@windymilla
Copy link
Collaborator

The first thing to note is that GG2's spellcheck is based on GG1's Spell Query. The old GG1 Spell check uses Aspell, which is problematic on Windows as it doesn't support utf8 properly. I don't intend to use Aspell in GG2.

  1. Although the GG1 Spell Query doesn't restrict its check to the selected range (as Spell Check does in GG1, though I didn't know about that feature), I don't see any reason why GG2's spell checker can't be limited to the selected range.
  2. That is like GG1 Spell Query.
  3. That is not accurate, I don't think. GG1 Spell Check also handles each occurrence of a word, not just one for every "png". It's clear it has to do that because some occurrences of "png" might be correct, and some incorrect, so the Spell Check has to be able to handle that. I suspect what happens is that when you see it is a word like "png" where you know all occurrences are OK, you do Skip All, or something similar in GG1 Spell Check. That's OK - you can do the same in GG2 Spelling Checker - just Shift Right Click a "png" warning message and they will all be removed from the list. Or you can click Skip All, or Add to Project Dictionary - both of those will remove all the warnings about "png" with one click.
  4. It's not emulating WF Spelling Check. However GG1 Spell Query has a feature that GG1 Spell Check does not, that many people have found helpful, and from your comment, you would too. It's "threshold" - you can say "if an apparent bad spelling occurs 3 or more times, then assume it's good". That feature hasn't yet been implemented in GG2 Spelling checker, but it will be.
  5. "Add Goodwords to Proj. Dictionary" is already in GG2, but it's in the File-->Project menu, because it can be useful for things other than Spell Check.

In summary, if you agree with my comments above, I think the following still need to be done:
a. Restrict GG2 spell checking to the selected range (or whole file if nothing selected).
b. Add "threshold" to the spell check dialog.

@okrick
Copy link
Author

okrick commented Jul 29, 2024

I agree with your comments and suggestions.

While I may have skimmed over GG1 Spell Query, similar to my experience with the WF Spelling check, it didn't align with my current process. As a result, I forgot it was there.

Incidentally, I find the GG1 Spell Check useful but I can live without it.

@windymilla
Copy link
Collaborator

Thanks for the additional info - it may be that with some additions, the Spell Query style will be acceptable too. If not, we'll have to review the way the GG2 spell checking works.

@windymilla windymilla linked a pull request Aug 2, 2024 that will close this issue
@windymilla windymilla added the core feature Required for basic PPing label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature Required for basic PPing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants