Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea for theming the app #34

Open
Atomlxe opened this issue May 12, 2024 · 6 comments
Open

idea for theming the app #34

Atomlxe opened this issue May 12, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Atomlxe
Copy link

Atomlxe commented May 12, 2024

i noticed the app seemingly uses msstyles for colors, would it be possible to instead support theming everything inside the app itself? there could be default preset themes, (light mode, dark mode, etc) but it would be nice to have a separate "advanced" tab to fully customize the colors of everything

@Atomlxe
Copy link
Author

Atomlxe commented May 12, 2024

i was gonna add the idea label to this aswell but im somewhat new to creating issues on github and could not figure out how to add it

@iProgramMC
Copy link
Contributor

iProgramMC commented May 12, 2024

I highly doubt it. You'd need to somehow figure out a way to load themes for JUST the app itself, and its controls. I'd have liked to add Win10/11 dark mode support, but it felt like too much work for what could potentially be an inconsistent mess.

If you aren't using a totally new (Windows 10 and 11) version of Windows then you can just modify your system theme if you want to use a different one on Discord. But that will apply to the entire system.

@iProgramMC iProgramMC added the enhancement New feature or request label May 12, 2024
@Atomlxe
Copy link
Author

Atomlxe commented May 12, 2024

odd idea and im not sure if this would even work, but would it be possible to make the app optionally accept msstyles files inside the app directory?

@iProgramMC
Copy link
Contributor

iProgramMC commented May 12, 2024

I'm pretty sure it wouldn't I'm afraid. In general Microsoft does not support custom msstyles seeing as you have to patch uxtheme.dll to remove the signature requirement. Most likely you are going to have to load the msstyles as your system theme.

@RF7391
Copy link

RF7391 commented May 12, 2024

https://winclassic.net/thread/2178/loading-visual-styles-application

There is a way to theme it per application

@iProgramMC
Copy link
Contributor

iProgramMC commented May 12, 2024

This is too much work with undocumented interfaces that could break, for too little effort. I am not going to be using that.

The most I'd do is add support for Windows 10/11 dark mode, even though that also depends on undocumented APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants