Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWM] Add pagination to ResultsPanel #55

Open
rogup opened this issue Nov 18, 2024 · 4 comments
Open

[CWM] Add pagination to ResultsPanel #55

rogup opened this issue Nov 18, 2024 · 4 comments

Comments

@rogup
Copy link
Contributor

rogup commented Nov 18, 2024

Description

We currently fetch all names matching a search to populate the ResultsPanel. This will probably become a performance issue if the dataset gets too big.

The search API supports pagination so we just need to implement this in the UI, maybe using this MUI component:
https://mui.com/material-ui/react-pagination/#controlled-pagination

Acceptance Criteria

  • [ ]
@ColmDC
Copy link

ColmDC commented Nov 20, 2024

Has this been implemented, so we can close? @rogup

@rogup
Copy link
Contributor Author

rogup commented Nov 20, 2024

@ColmDC No, for now, I've just truncated the list to 200 so loading isn't too slow, and the user can't see past the first 200 items unless they refine their search f4b295f

@ColmDC
Copy link

ColmDC commented Dec 4, 2024

Can you estimate how big a task this would be?

@rogup
Copy link
Contributor Author

rogup commented Dec 5, 2024

I reckon 1-1.5 days: 0.5-1 day to design and create the pagination UI component, then half a day to link it up to the API and write Redux UTs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants