Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LX Collab Mapping] Read, write, own map permissions #307

Closed
lin-d-hop opened this issue Jan 19, 2024 · 7 comments · Fixed by DigitalCommons/land-explorer-back-end#55
Closed
Assignees
Labels

Comments

@lin-d-hop
Copy link
Contributor

lin-d-hop commented Jan 19, 2024

Please track under the clockify project [LX Collab Mapping]

Description

Following on from #304
Currently users can own maps that they create. They can share these maps as read-only with other users.

We want to implement three levels of map permissions:
Read - as per the current read only, the user can see the map and interact with elements but cannot add or edit the map
Write - the user can see the map, interact, add and edit elements on the map.
Own - as per the current owner. Can write. Can also delete the map and share the map with other users.

Additional complications arise with write are explored in #306, which is likely a prerequisite for this piece.

Acceptance Criteria

  • Three potential permission levels exist on maps.
  • The access granted with each permission level is as described above.
  • Unit tests as standard
@ms0ur1s
Copy link
Collaborator

ms0ur1s commented Jan 29, 2024

Not sure how long this hasn't worked for, but get the same result both locally and live (now resolved) locally. So map sharing's not working.

image

image

Changes to mapSharing function

image

image

@ms0ur1s
Copy link
Collaborator

ms0ur1s commented Jan 31, 2024

Read and write permission pushed to the BE, base on FE selection. Only map owner status is outstanding.

image

@lin-d-hop
Copy link
Contributor Author

@ms0ur1s How's this work coming along?
Will be great ot be new and improved map sharing online :)

@ms0ur1s
Copy link
Collaborator

ms0ur1s commented Mar 7, 2024

@ms0ur1s How's this work coming along? Will be great to be new and improved map sharing online :)

Hi @lin-d-hop, apologies, as with #308 the hold-up is #306 which I'll organise to Rohit so we can resolve it.

@lin-d-hop lin-d-hop changed the title [Oxon] Read, write, own map permissions [LX Collab Mapping] Read, write, own map permissions Mar 19, 2024
@rogup
Copy link
Collaborator

rogup commented Mar 20, 2024

@ms0ur1s are you creating a UI for a map owner to assign either write or read permissions to another user? It's not clear whether this is in the scope of the issue

@ms0ur1s
Copy link
Collaborator

ms0ur1s commented Mar 20, 2024

Hey @rogup, yep that was done in either #306 or #308.

@rogup
Copy link
Collaborator

rogup commented Apr 1, 2024

This work will be done within the PR linked to #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants