-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuraton Overrides #5
Comments
I am also having this issue, there is a closed ticket about it where someone was able to resolve it on an earlier version but I can't get it to work with this one. I get the same persistent If the additional server settings could be added to the ENV options we would be in business. |
Right now the easiest workaround would be to define V_RISING_SERVER_DEFAULT_HOST_SETTINGS as false, which disables using the default config as a template, which it would then apply customizations to. I'm working on bringing this project back to life, so it's unfortunately a bit of a work in progress right now, and there have been seemingly undocumented changes to the actual V Rising server, so getting all of those changes working and supporting all kinds of custom configs, as well as properly documenting usage, is something that will take a bit more time. |
When I set V_RISING_SERVER_DEFAULT_HOST_SETTINGS to false, my manually set ServerHostSettings.json file gets overwritten with default settings when starting the container. |
I have done this as well, the settings were overridden . |
Okay, I was able to get my settings to persist by commenting out lines 220-234 in start_vrising.sh. I have 3 servers currently down, so I am trying to just get them running. But, I will take a deeper look and see if I can't resolve this with a PR. |
Yeah, still no joy for me. |
I first commented out the following lines in start_vrising.sh: Here is my docker-compose setup: Good luck! |
I'll try getting this fixed today and will update here once the new image is published. Once that's done, be sure to use the "latest" tag when pulling the new image, to ensure you get the newest available image. |
Thank you! I was thinking about altering the template for server host file and firering up the container to see if it would pull from that next, but I will just wait for the new image :D |
Shotgun committing untested potential fixes to #5 Signed-off-by: Pauli Jokela <[email protected]>
Any updates on this? I'm still getting this issue myself, and i've even tried deleting and re-pulling the latest container from dockerhub to see if i had an older container that wasn't fixed yet, but nope. The container still changes |
To stop the config override I disabled the following via environmental variables V_RISING_SERVER_DEFAULT_HOST_SETTINGS: false I found this in the startup.sh script |
Even with setting those env vars to false, it is still overwriting the settings with the defaults |
Got an example env file? As soon as I applied those above settings, both my config files stopped getting overridden and I've had the server running for weeks now, restarting nightly and never override |
it might be related to #10, some of the jq statements, especially the bools, didn't work |
This container is great but I seem to be having a few issues with configuration.
Setting
- V_RISING_SERVER_LIST_ON_EOS=true
in mydocker_compose.yml
still results inListOnEOS
being false in the loadedServerHostSettings
.If I try to set it in the
ServerHostSettings.json
that file seems to be recreated with fresh values every time the docker container is started. So if I set it there and start the server it will be turned back to false. Any idea how I can enable the settings?The text was updated successfully, but these errors were encountered: