Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuraton Overrides #5

Open
fulrich opened this issue May 21, 2023 · 14 comments
Open

Configuraton Overrides #5

fulrich opened this issue May 21, 2023 · 14 comments

Comments

@fulrich
Copy link

fulrich commented May 21, 2023

This container is great but I seem to be having a few issues with configuration.

Setting - V_RISING_SERVER_LIST_ON_EOS=true in my docker_compose.yml still results in ListOnEOS being false in the loaded ServerHostSettings.

If I try to set it in the ServerHostSettings.json that file seems to be recreated with fresh values every time the docker container is started. So if I set it there and start the server it will be turned back to false. Any idea how I can enable the settings?

@danielzrob
Copy link

danielzrob commented May 21, 2023

I am also having this issue, there is a closed ticket about it where someone was able to resolve it on an earlier version but I can't get it to work with this one.

I get the same persistent ServerHostSettings.json issue. I have tried messing with the ENV settings and I found out I'm really great at breaking the build.

If the additional server settings could be added to the ENV options we would be in business.

@Dids
Copy link
Contributor

Dids commented May 22, 2023

Right now the easiest workaround would be to define V_RISING_SERVER_DEFAULT_HOST_SETTINGS as false, which disables using the default config as a template, which it would then apply customizations to.

I'm working on bringing this project back to life, so it's unfortunately a bit of a work in progress right now, and there have been seemingly undocumented changes to the actual V Rising server, so getting all of those changes working and supporting all kinds of custom configs, as well as properly documenting usage, is something that will take a bit more time.

@acarlson1994
Copy link

V_RISING_SERVER_DEFAULT_HOST_SETTINGS

When I set V_RISING_SERVER_DEFAULT_HOST_SETTINGS to false, my manually set ServerHostSettings.json file gets overwritten with default settings when starting the container.

@danielzrob
Copy link

I have done this as well, the settings were overridden .

@acarlson1994
Copy link

acarlson1994 commented May 24, 2023

Okay, I was able to get my settings to persist by commenting out lines 220-234 in start_vrising.sh. I have 3 servers currently down, so I am trying to just get them running. But, I will take a deeper look and see if I can't resolve this with a PR.

@danielzrob
Copy link

Yeah, still no joy for me.

@acarlson1994
Copy link

acarlson1994 commented May 25, 2023

Yeah, still no joy for me.

I first commented out the following lines in start_vrising.sh:
image

Here is my docker-compose setup:
image
Note that most of the config is commented out, and it was very trial and error based to get it all working. Plus the RCON config was still being overridden by the start_vrising.sh file, so don't expect to customize that without more modification.

Good luck!

@Dids
Copy link
Contributor

Dids commented May 25, 2023

I'll try getting this fixed today and will update here once the new image is published. Once that's done, be sure to use the "latest" tag when pulling the new image, to ensure you get the newest available image.

@danielzrob
Copy link

Thank you! I was thinking about altering the template for server host file and firering up the container to see if it would pull from that next, but I will just wait for the new image :D

Dids added a commit that referenced this issue May 26, 2023
Shotgun committing untested potential fixes to #5 

Signed-off-by: Pauli Jokela <[email protected]>
@spongeyperson
Copy link

Any updates on this? I'm still getting this issue myself, and i've even tried deleting and re-pulling the latest container from dockerhub to see if i had an older container that wasn't fixed yet, but nope. The container still changes V_RISING_SERVER_LIST_ON_EOS=true & V_RISING_SERVER_LIST_ON_STEAM=true back to false when started back up, even with docker-compose.yml set to V_RISING_SERVER_START_MODE: "2" and V_RISING_SERVER_UPDATE_MODE: "0" so steamcmd doesn't grab new files or updates.

@scycer
Copy link

scycer commented Jun 27, 2023

To stop the config override I disabled the following via environmental variables

V_RISING_SERVER_DEFAULT_HOST_SETTINGS: false
V_RISING_SERVER_DEFAULT_GAME_SETTINGS: false

I found this in the startup.sh script

@q23407u892f
Copy link

Even with setting those env vars to false, it is still overwriting the settings with the defaults

@scycer
Copy link

scycer commented Jul 15, 2023

Even with setting those env vars to false, it is still overwriting the settings with the defaults

Got an example env file? As soon as I applied those above settings, both my config files stopped getting overridden and I've had the server running for weeks now, restarting nightly and never override

@halkeye
Copy link

halkeye commented Oct 30, 2023

it might be related to #10, some of the jq statements, especially the bools, didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants