Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command execution shouldn't occur when CORS allowed origin is not valid #57

Open
lucifercr07 opened this issue Dec 11, 2024 · 3 comments
Open

Command execution shouldn't occur when CORS allowed origin is not valid #57

lucifercr07 opened this issue Dec 11, 2024 · 3 comments
Assignees
@mayank2424

Comments

@lucifercr07
Copy link
Contributor

Steps to reproduce:

  • Trigger command from UI with origin not part of configValue.Server.AllowedOrigins
  • Command execution will still happen and response returned is not proper.
image

Expected output:

  • Triggered command should fail with proper error response and no command execution
@mayank2424
Copy link

@lucifercr07 I would like to take this up. Could you please assign the issue to me?

@lucifercr07
Copy link
Contributor Author

@mayank2424 assigned, thanks for contributing.

@mayank2424
Copy link

@mayank2424 assigned, thanks for contributing.

@lucifercr07 Here is a pull request for the changes - #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayank2424 mayank2424

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucifercr07 @mayank2424