Update to work with pvsxlibs 1.3.0 #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 87.73% 87.43% -0.30%
==========================================
Files 14 14
Lines 1019 1019
==========================================
- Hits 894 891 -3
- Misses 125 128 +3 ☔ View full report in Codecov by Sentry. |
AlexanderWells-diamond
force-pushed
the
pvxs_fix
branch
from
2b26f4a to
dccdeef
Compare
This version changed the name of its inbuilt .dbd files, which we must match in order to load it Also updated various other dependencies in order to make the pipenv environment stable
AlexanderWells-diamond
force-pushed
the
pvxs_fix
branch
from
dccdeef to
dd63ac8
Compare
|
@mdavidsaver is this the correct fix? |
This was not intentional (epics-base/pvxs#65). fyi. renaming/removal of a .dbd file is to my mind an incompatible API change, which would trigger a major version increment. |
|
Fixed in pvxslibs==1.3.1. I have "yanked" 1.3.0 on pypi.org. It would help in detecting issues like this if pythonSoftIOC could add a CI job testing the current 'master' branches of epicscorelibs, pvxs, and p4p. |
|
PR is no longer necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version changed the name of its inbuilt .dbd files, which we must match in order to load it
Also updated various other dependencies in order to make the pipenv environment stable
Closes #145