Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Bundle creation/deletion) Having a tenant-specific include in an include that is used in a script does not generate a tenant specific version of the script #600

Open
kharybdys opened this issue Jul 23, 2021 · 2 comments
Open

(Bundle creation/deletion) Having a tenant-specific include in an include that is used in a script does not generate a tenant specific version of the script #600

kharybdys opened this issue Jul 23, 2021 · 2 comments
Assignees
@kharybdys

Comments

@kharybdys
Copy link
Contributor

See the junit tests in BundleManipulationTest, test testBundleCreationWithDoubleLayerInclude. The final assertion should work but it currently fails.

It is verified that the current navajo system also exhibits the same, wrong, behaviour.
@kharybdys kharybdys self-assigned this Jul 23, 2021
@kharybdys
Copy link
Contributor Author

First analysis suggests because the dependency logic only remembers the attributes of the current dependency and does not recurse or inherit the tenant specifity of its own include.

@kharybdys
Copy link
Contributor Author

Note that more tests in the same class fail for this reason. They have this issue number next to them as a marker to turn them back on once fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kharybdys kharybdys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kharybdys