Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper support for locale header in function GetValidationDescription #580

Open
roelofkemp opened this issue Mar 1, 2021 · 1 comment
Open

Proper support for locale header in function GetValidationDescription #580

roelofkemp opened this issue Mar 1, 2021 · 1 comment
Assignees
@roelofkemp
Labels
3 - In Test Changes have been deployed in the test environment. bug Something isn't working

Comments

@roelofkemp
Copy link
Contributor

Currently the GetValidationDescription function only applies a locale when passed as a second parameter to the function, but ignores any locale that might be present in header attribute "locale" (such as the Lookup function does).

This should be fixed similar to the Lookup function, by checking the "locale" header, allowing for this to be overridden by a second parameter and falling back on the default language.
@roelofkemp roelofkemp self-assigned this Mar 1, 2021
@roelofkemp roelofkemp mentioned this issue Mar 1, 2021
Merged
@ghost ghost closed this as completed in c7266a9 Jun 10, 2021
ghost pushed a commit that referenced this issue Jun 10, 2021
Merge pull request #581 from Dexels/_fix_issue580
575dbe0 
fixes #580: Proper support for locale header in function GetValidationDescription
@ghost ghost reopened this Jun 10, 2021
@ghost ghost added 3 - In Test Changes have been deployed in the test environment. bug Something isn't working labels Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Released as bundle com.dexels.navajo.function version 3.5.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roelofkemp roelofkemp

Labels
3 - In Test Changes have been deployed in the test environment. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roelofkemp