Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property getValue vs. getTypedValue and null return values #579

Open
roelofkemp opened this issue Jan 29, 2021 · 2 comments
Open

Property getValue vs. getTypedValue and null return values #579

roelofkemp opened this issue Jan 29, 2021 · 2 comments
Labels
6 - Paused Work on this issue has been paused. bug Something isn't working

Comments

@roelofkemp
Copy link
Contributor

It can happen that properties of certain types return null for the getValue, but not for the getTypedValue and the other way around.

Example 1: getValue() == null and getTypedValue() != null
for all properties that have a value that is not backed by a string representation (for instance selection properties)

Example 2: getValue() != null and getTypedValue() == null
for all properties where the value cannot be parsed into the correct type. For instance an integer that has a string representation that is greater than MAX_INT.

Ideally both methods should return null or both should return not-null.

@ghost ghost self-assigned this Jun 9, 2021
@ghost ghost added 1 - Ready Ready to start working on this issue. bug Something isn't working 2 - Working Working on this issue. and removed 1 - Ready Ready to start working on this issue. labels Jun 9, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

There are currently ...

  • 486 references to / uses of getValue().
  • 418 references to / uses of getTypedValue().

@ghost ghost added 6 - Paused Work on this issue has been paused. and removed 2 - Working Working on this issue. labels Jun 15, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

I am pausing this issue since changes to the semantics of these functions are inherently risky (given the lack of proper regression tests in the code base).

@ghost ghost removed their assignment Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Paused Work on this issue has been paused. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant